I love sticking with a particular phone for as long as I want since its not faulty.
I'd prefer to use a smartphone for at least 2 years. This is because smartphones are constantly being updated with new features and software, so it's best to upgrade every few years to get the most out of your device.
However, if you're happy wit your current phone and it's still working well, there's no need to upgrade right away.